Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a critical security bug in the wolfBoot_unlock_disk function where sensitive cryptographic data was not being properly cleared from memory. The bug used sizeof(secretSz) (size of an int variable) instead of sizeof(secret) (size of the buffer array) in a call to TPM2_ForceZero, resulting in only 4 bytes being zeroed instead of the entire secret buffer.
Changes:
- Fixed incorrect sizeof argument in TPM2_ForceZero call to properly zero the entire secret buffer instead of just the first 4 bytes
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
LinuxJedi
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix wrong sizeof
Fenrir issue M-32