Improve image header default size, check for dupe hash def#648
Merged
danielinux merged 1 commit intowolfSSL:masterfrom Dec 12, 2025
Merged
Improve image header default size, check for dupe hash def#648danielinux merged 1 commit intowolfSSL:masterfrom
danielinux merged 1 commit intowolfSSL:masterfrom
Conversation
dgarske
approved these changes
Dec 8, 2025
danielinux
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Properly assign
IMAGE_HEADER_SIZEdefault value.Fixes validations failures in image.c verify when
IMAGE_HEADER_SIZEnot defined and called from thetest-libapp.While working on #623 and adding matrix support for more combinations, I encountered an odd problem where the test-lib would fail to validate.
The root cause is this blanket assignment that uses a value of 256, regardless of actual sign/hash needs:
Most of the make and cmake builds probably set this. There was no logic for it in my Visual Studio builds.
Tested here:
https://github.com/gojimmypi/wolfBoot/actions/runs/19991079444
While here, I also added a check for multiple hash assignments with a hard compile-time fail.
(yes, I did this accidentally, no, it's not an intuitive error, lol)