Pic32c: fix unaligned read, always check flash done after flash operations#575
Merged
dgarske merged 2 commits intowolfSSL:masterfrom Jun 19, 2025
Merged
Pic32c: fix unaligned read, always check flash done after flash operations#575dgarske merged 2 commits intowolfSSL:masterfrom
dgarske merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes flash operation issues on the PIC32C by ensuring flash operations complete with proper error checking and handling unaligned flash writes. Key changes include defining a specific word size constant, updating the data pointer type for aligned flash writes, and adding a new test case for unaligned flash source writes.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| hal/pic32c.c | Added a new constant for word size, updated flash write function to use uint32_t pointers, and refined error handling after flash operations. |
| hal/hal.c | Introduced a new unaligned flash write test and modified flash test logic to validate unaligned source handling. |
Comments suppressed due to low confidence (1)
hal/hal.c:184
- The comment indicates that src is 40 bytes, but 9 uint32_t elements typically occupy 36 bytes. Please update the comment to accurately reflect the actual size.
uint32_t src[9]; /* 40 bytes */
dgarske
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.