Skip to content

Pic32c: fix unaligned read, always check flash done after flash operations#575

Merged
dgarske merged 2 commits intowolfSSL:masterfrom
rizlik:pic32_fixes
Jun 19, 2025
Merged

Pic32c: fix unaligned read, always check flash done after flash operations#575
dgarske merged 2 commits intowolfSSL:masterfrom
rizlik:pic32_fixes

Conversation

@rizlik
Copy link
Contributor

@rizlik rizlik commented Jun 19, 2025

No description provided.

@rizlik rizlik requested review from Copilot and dgarske June 19, 2025 15:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes flash operation issues on the PIC32C by ensuring flash operations complete with proper error checking and handling unaligned flash writes. Key changes include defining a specific word size constant, updating the data pointer type for aligned flash writes, and adding a new test case for unaligned flash source writes.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
hal/pic32c.c Added a new constant for word size, updated flash write function to use uint32_t pointers, and refined error handling after flash operations.
hal/hal.c Introduced a new unaligned flash write test and modified flash test logic to validate unaligned source handling.
Comments suppressed due to low confidence (1)

hal/hal.c:184

  • The comment indicates that src is 40 bytes, but 9 uint32_t elements typically occupy 36 bytes. Please update the comment to accurately reflect the actual size.
    uint32_t src[9]; /* 40 bytes */

@dgarske dgarske merged commit 374d605 into wolfSSL:master Jun 19, 2025
260 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants