606 extend histogram #646
606 extend histogram #646
Conversation
- Adding bin central value vector - Adaption of histogram statistics to ExtendedImageInfo
src/histogram.rs
Outdated
| } | ||
| if has_alpha{ | ||
| let alpha: f32 = chunk[USEFUL_CN].into(); | ||
| transparent_pixels += (alpha<=f32::EPSILON && trans) as u64; |
There was a problem hiding this comment.
I don't think this is correct. I think there is specialization needed
trait AlphaTest{
fn is_transparent_alpha(self)
}
impl AlphaTest for u8 {
fn is_transparent_alpha(self) {
self != 255
}
}something like that.
Also it is not seems to be correct for edge cases image
https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=e96e6185633076b554739d50d5a210cf
There was a problem hiding this comment.
Hmm, I just adapted it to the old logic, where only vectors with all zero components are counted:
fn is_pixel_fully_transparent(p: &Rgba) -> bool {
p.0 == [0, 0, 0, 0]
}
For this I think it's correct?
NaN and Inf is a really good hint, what would you do with them?
I'd think:
NaN => 0
Inf => 1
There was a problem hiding this comment.
I believe there is should be
if f.is_nan() {
f32::MAX // Or any local positive extremum, as 1, 255, 65535 etc
} else if f32::INFINITY == f {
f32::MAX // Or any local positive extremum, as 1, 255, 65535 etc
} else if f32::NEG_INFINITY == f {
f32::MIN // Or any local negative extremum, 0 if u8, u16 type required
} else if f.is_subnormal() {
0. // Non-transparent value, since 1/65535 is subnormal, but for 16 bit-depth it is not transparent :)
} else {
f
}There was a problem hiding this comment.
I believe there is should be
if f.is_nan() { f32::MAX // Or any local positive extremum, as 1, 255, 65535 etc } else if f32::INFINITY == f { f32::MAX // Or any local positive extremum, as 1, 255, 65535 etc } else if f32::NEG_INFINITY == f { f32::MIN // Or any local negative extremum, 0 if u8, u16 type required } else if f.is_subnormal() { 0. // Non-transparent value, since 1/65535 is subnormal, but for 16 bit-depth it is not transparent :) } else { f }
You're right - except for the subnormals, I think: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=aff576713b574afb03c086b2f776d826
So adding the trait you suggested makes sense here, because we don't need all these branches for u8 and u16.
First try for scaling min/max in ArgumentReducer
No description provided.