Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vicky: rename lock..object to lock..name #20

Merged
merged 2 commits into from
Apr 24, 2024
Merged

vicky: rename lock..object to lock..name #20

merged 2 commits into from
Apr 24, 2024

Conversation

Kek5chen
Copy link
Contributor

improve clarity

@Kek5chen Kek5chen self-assigned this Apr 24, 2024
@Kek5chen Kek5chen linked an issue Apr 24, 2024 that may be closed by this pull request
vicky: Rename Lock.*.object to Lock.*.name #19
Closed
johannwagner
johannwagner approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@johannwagner johannwagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, this changes the exposed API. Please add a documentation addition for locks in general, currently there are no locks in API.md described.

@Kek5chen Kek5chen merged commit 1f01bb4 into main Apr 24, 2024
4 checks passed
@Kek5chen Kek5chen deleted the refactor/rename-obj-to-name branch April 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannwagner johannwagner johannwagner approved these changes

Assignees

@Kek5chen Kek5chen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vicky: Rename Lock.*.object to Lock.*.name
2 participants
@Kek5chen @johannwagner