Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solved issue #1 (Invalid Roll Numbers) #14

Closed
wants to merge 1 commit into from
Closed

Solved issue #1 (Invalid Roll Numbers) #14

wants to merge 1 commit into from

Conversation

madhav48
Copy link

Added function to validate roll numbers to block invalid roll numbers being allowed during registration

@madhav48
Solved issue #1 (Invalid Roll Numbers)
8772ce5 
Added function to validate roll numbers to block invalid roll numbers being allowed during registration
@Prater-12 Prater-12 added the backend Related to the backend label Oct 31, 2023
Prater-12
Prater-12 requested changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@Prater-12 Prater-12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your function does not account for roll numbers like 22M1001 (Masters) and pre-22 roll numbers that are not 7 characters long.

You also need to raise a ValidationError when the roll number is incorrect, not just return "void".

@madhav48
Copy link
Author

Can you please give some examples of pre-22 roll numbers?

@Prater-12
Copy link
Collaborator

Prater-12 commented Oct 31, 2023 •
edited
Loading

Can you please give some examples of pre-22 roll numbers?

210040001 is a valid roll number for the '21 batch, Civil Engg. (B.Tech)

Some more googling brought up this link from the IEOR website that has some roll numbers corresponding to PG students.

@Prater-12 Prater-12 linked an issue Oct 31, 2023 that may be closed by this pull request
accounts: Invalid roll numbers being allowed during registration #1
Open
@madhav48 madhav48 closed this by deleting the head repository Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Prater-12 Prater-12 Prater-12 requested changes

Assignees
No one assigned
Labels
backend Related to the backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

accounts: Invalid roll numbers being allowed during registration
2 participants
@madhav48 @Prater-12