Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization of roll number done #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

TirthGada
Copy link

normalised the roll number by creating a function named normalize_roll_number which makes the roll number to uppercase

@Prater-12
Copy link
Collaborator

Since _create_user is called even on the admin backend for user creation, this approach is a bit more restrictive than adding a similar check to the serializer (an approach that has been proposed in a previous PR), thus only adding this restriction to users. However, I could see escaping certain specific user names like admin or root.

@Prater-12 Prater-12 linked an issue Oct 28, 2023 that may be closed by this pull request
@Prater-12 Prater-12 added the backend Related to the backend label Oct 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to the backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accounts: Normalize roll number to ensure uniformity
2 participants