Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permissions for composer.local.json #754

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rti
Copy link
Contributor

@rti rti commented Aug 15, 2024

Depending on docker daemon user and github action checkout user, permissions on this file could differ, even breaking the build if not readable by the current user in the container build process. This patch ensures correct permissions.

Appeared as a problem on a self hosted github actions runner.

Depending on docker daemon user and github action checkout user,
permissions on this file could differ, even breaking the build if not
readable by the current user in the container build process. This patch
ensures correct permissions.

Appeared as a problem on a self hosted github actions runner.
@rti rti requested review from lorenjohnson and a team and removed request for lorenjohnson August 15, 2024 12:47
Copy link
Contributor

@lorenjohnson lorenjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe a comment in the Dockerfile to remind our future selves why this seemed necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants