-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Codex tokens and custom spacing variables #762
Conversation
6b0162c
to
41e42f3
Compare
41e42f3
to
d13bac4
Compare
Is there a reason to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to go through the changes and figure out which task they correspond to and whether they’re right or not. Many of the comments are just acknowledgements, but I think some represent issues.
d13bac4
to
a9d7f41
Compare
I'm not super opinionated. I think the intention was to have a CSS file at the end of the migration that we could try an upstream to Codex to have them add the variables to the CSS, but we could also keep the missing variables in Sass in our repo for now. |
I’d prefer to make them Sass variables for now and then potentially reevaluate that at the end of T375370, but I’m also okay with keeping them as they are. (The other questions are now blocked on feedback from UX IIUC.) |
a9d7f41
to
030fc4b
Compare
Updated per UX feedback - should be good to go now. |
There’s currently too much space before the lexeme language / lexical category asterisks, but I think that’s just a consequence of #773 being blocked – the asterisks currently have both the gap on the surrounding label and the margin that’s supposed to replace the gap, if I understand correctly. |
Migrate away from Wikit tokens to Codex SASS variables where they are available. In some cases we use custom CSS variables for values from Wikit whose Codex equivalents are missing.
Bug: T369510
Bug: T369508
Bug: T369509