Do not replace legacy FX with new PS FX #5193
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed, we should keep legacy functions and FX if possible. Since PS replacements is purely a flash saving matter we should not enforce progress to users until the need for reducing flash size arises.
What this PR does is enable the
WLED_PS_DONT_REPLACE_FXflag on all builds, keeping all legacy FX.edit: flash cost is 8k
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.