Skip to content

Conversation

@DedeHai
Copy link
Collaborator

@DedeHai DedeHai commented Dec 14, 2025

as discussed, we should keep legacy functions and FX if possible. Since PS replacements is purely a flash saving matter we should not enforce progress to users until the need for reducing flash size arises.

What this PR does is enable the WLED_PS_DONT_REPLACE_FX flag on all builds, keeping all legacy FX.

edit: flash cost is 8k

Summary by CodeRabbit

  • Chores
    • Added a new build configuration flag to provide an option for controlling effects behavior during firmware compilation.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 14, 2025

Walkthrough

A build flag WLED_PS_DONT_REPLACE_FX is added to platformio.ini with a comment indicating that particle system replacement effects should not replace classic effects until flash memory is exhausted.

Changes

Cohort / File(s) Summary
Build configuration
platformio.ini
Added build flag -D WLED_PS_DONT_REPLACE_FX to control particle system replacement behavior, with documentation note that PS replacement FX should not replace classic FX until flash is exhausted

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Single configuration line addition with inline documentation
  • No logic changes or code modifications

Possibly related PRs

Suggested reviewers

  • softhack007
  • netmindz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: adding the WLED_PS_DONT_REPLACE_FX flag to prevent legacy FX replacement with new PS FX in platformio.ini.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@DedeHai DedeHai mentioned this pull request Dec 14, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants