-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
platformio sample cleanup #5190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughRemoves multiple legacy and specialized board environment configurations from platformio_override.sample.ini, including heltec_wifi_kit_8, esp8285 variants, anavi_miracle_controller, MY9291, and codm-controller boards. Also applies minor comment adjustments to remaining environment sections. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (7)📓 Common learnings📚 Learning: 2025-10-05T15:24:05.545ZApplied to files:
📚 Learning: 2025-11-22T20:33:14.840ZApplied to files:
📚 Learning: 2025-02-19T12:43:34.199ZApplied to files:
📚 Learning: 2025-10-05T15:24:05.545ZApplied to files:
📚 Learning: 2025-09-02T02:27:39.220ZApplied to files:
📚 Learning: 2025-07-06T16:15:24.051ZApplied to files:
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I've left Athom for now as I know these are in common use and I don't know the current state of play with regards to their firmware |
| # ------------------------------------------------------------------------------ | ||
| # EleksTube-IPS | ||
| # ------------------------------------------------------------------------------ | ||
| [env:elekstube_ips] | ||
| extends = esp32 ;; use default esp32 platform | ||
| board = esp32dev | ||
| upload_speed = 921600 | ||
| custom_usermods = ${env:esp32dev.custom_usermods} RTC EleksTube_IPS | ||
| build_flags = ${common.build_flags} ${esp32.build_flags} -D WLED_DISABLE_BROWNOUT_DET -D WLED_DISABLE_INFRARED | ||
| -D DATA_PINS=12 | ||
| -D RLYPIN=27 | ||
| -D BTNPIN=34 | ||
| -D PIXEL_COUNTS=6 | ||
| # Display config | ||
| -D ST7789_DRIVER | ||
| -D TFT_WIDTH=135 | ||
| -D TFT_HEIGHT=240 | ||
| -D CGRAM_OFFSET | ||
| -D TFT_SDA_READ | ||
| -D TFT_MOSI=23 | ||
| -D TFT_SCLK=18 | ||
| -D TFT_DC=25 | ||
| -D TFT_RST=26 | ||
| -D SPI_FREQUENCY=40000000 | ||
| -D USER_SETUP_LOADED | ||
| monitor_filters = esp32_exception_decoder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a usermod example that's in the wrong place - probably a bad merge moved the header comment. I think it should get moved to the EleksTube_IPS usermod readme (and we should do the same with the RF433 example too)
Remove bespoke boards from platformio-override.sample.ini as these are not maintained
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.