Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: without automatic PMTU, tell client about static PMTU #130

Merged
merged 4 commits into from
Apr 10, 2020

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 7, 2020

this informs the client about our MTU so both sides use the same

@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2020

@kaechele what do you think about this? How do you handle MTUs in your network?

@mitar
Copy link
Member

mitar commented Apr 8, 2020

Why would automatic PMTU not work?

@mitar
Copy link
Member

mitar commented Apr 8, 2020

So Tunneldigger has a custom implementation.

@RalfJung
Copy link
Member Author

RalfJung commented Apr 8, 2020

We talked about this a while ago in #62. Note that tunneldigger already has support for disabling auto-PMTU, this just improves that support.

I also think that for our use-case, automatic PMTU is rather useless: we are running a batman mesh network on top of tunneldigger, and the entire mesh is a single layer 2 domain. This means the entire mesh needs to have a single MTU. I do not see how determining precisely the MTU of each tunnel is useful when on top of that tunnel, we anyway need to work with a single MTU that works for everyone. That's why we statically configure a suitably small tunneldigger MTU in our network, which seems to work.

@mitar
Copy link
Member

mitar commented Apr 9, 2020

I see. Thanks.

@RalfJung RalfJung changed the title without automatic PMTU, tell client about static PMTU broker: without automatic PMTU, tell client about static PMTU Apr 10, 2020
@RalfJung
Copy link
Member Author

All right, merging then. We've been using this in production for a few weeks now.

@RalfJung RalfJung merged commit 9349948 into wlanslovenija:master Apr 10, 2020
@RalfJung RalfJung deleted the server_pmtu branch April 10, 2020 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants