-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow versions of MongoEngne greater than 0.8.1 #68
base: master
Are you sure you want to change the base?
Conversation
I'm not able to use django-tastypie-mongoengine because it presently limits the maximum version of MongoEngine to 0.8.1. This allows it to use any version of MongoEngine >= 0.8.1.
Have you seen that tests fail with versions greater than 0.8.1? This means you might be able to install it, but it will not work correctly. There is a reason why version is limited: so that you get a working version. See this ticket for more information: MongoEngine/mongoengine#381 |
BTW, this pull request is missing changing of limits on versions for Travis CI testing. So testing is still done on 0.8.1, while you removed the limits. Remove the limits in |
I'll have to look into this. If you can give me an idea of why tests fail in particular with future versions of MongoEngine, I might work on a bigger pull request to patch it and get things working and get all tests passing. |
I linked the MongoEngine ticket. Tests fail because they broke one thing. |
Hello @mitar and @rfkrocktk , What is the status of this issue ? Thanks ! |
Nothing has been changed AFAIK. You must use mongoengine == 0.8.1 to use django_tastypie_mongoengine. |
Please comment and urge on this ticket for MongoEngine to fix their codebase: MongoEngine/mongoengine#381 |
@mitar @rfkrocktk Hi guys, as the fix is planned for 0.9 and I think we won't have it for a long time, is it possible to create a tagged release on github without the mongoengine requirement ? : https://pip.pypa.io/en/latest/reference/pip_install.html#requirements-file-format It will allow those who need last mongoengine to use it, even if there's a bug and not having problem with requirements.txt file. |
I'm not able to use django-tastypie-mongoengine because it presently limits the maximum version of MongoEngine to 0.8.1. This allows it to use any version of MongoEngine >= 0.8.1.