Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow versions of MongoEngne greater than 0.8.1 #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

naftulikay
Copy link

I'm not able to use django-tastypie-mongoengine because it presently limits the maximum version of MongoEngine to 0.8.1. This allows it to use any version of MongoEngine >= 0.8.1.

I'm not able to use django-tastypie-mongoengine because it presently limits the maximum version of MongoEngine to 0.8.1. This allows it to use any version of MongoEngine >= 0.8.1.
@mitar
Copy link
Member

mitar commented Oct 16, 2013

Have you seen that tests fail with versions greater than 0.8.1? This means you might be able to install it, but it will not work correctly. There is a reason why version is limited: so that you get a working version.

See this ticket for more information: MongoEngine/mongoengine#381

@mitar
Copy link
Member

mitar commented Oct 16, 2013

BTW, this pull request is missing changing of limits on versions for Travis CI testing. So testing is still done on 0.8.1, while you removed the limits. Remove the limits in .travis.yaml as well and you will see tests fail.

@naftulikay
Copy link
Author

I'll have to look into this.

If you can give me an idea of why tests fail in particular with future versions of MongoEngine, I might work on a bigger pull request to patch it and get things working and get all tests passing.

@mitar
Copy link
Member

mitar commented Oct 16, 2013

I linked the MongoEngine ticket. Tests fail because they broke one thing.

@Seraf
Copy link

Seraf commented Apr 11, 2014

Hello @mitar and @rfkrocktk ,

What is the status of this issue ?
In my requirements.txt, I need to use mongoengine >= 0.8.6 and use django_tastypie_mongoengine too but it fails due to :
error: Installed distribution mongoengine 0.8.7 conflicts with requirement mongoengine>=0.8.1,<0.8.2

Thanks !

@naftulikay
Copy link
Author

Nothing has been changed AFAIK. You must use mongoengine == 0.8.1 to use django_tastypie_mongoengine.

@mitar
Copy link
Member

mitar commented Apr 12, 2014

Please comment and urge on this ticket for MongoEngine to fix their codebase: MongoEngine/mongoengine#381

@Seraf
Copy link

Seraf commented Sep 19, 2014

@mitar @rfkrocktk Hi guys, as the fix is planned for 0.9 and I think we won't have it for a long time, is it possible to create a tagged release on github without the mongoengine requirement ? : https://pip.pypa.io/en/latest/reference/pip_install.html#requirements-file-format

It will allow those who need last mongoengine to use it, even if there's a bug and not having problem with requirements.txt file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants