metrics(ticdc): fix some missing db sorter related metrics (pingcap#1…

…1547) close pingcap#11574
wk989898 · Sep 24, 2024 · e024400 · e024400
1 parent b7f98be
commit e024400
Show file tree

Hide file tree

Showing 7 changed files with 271 additions and 547 deletions.
diff --git a/cdc/scheduler/internal/v3/agent/agent.go b/cdc/scheduler/internal/v3/agent/agent.go
@@ -214,7 +214,7 @@ func (a *agent) Tick(ctx context.Context) (*schedulepb.Barrier, error) {
 
 	outboundMessages = append(outboundMessages, responses...)
 
-	if err := a.sendMsgs(ctx, outboundMessages); err != nil {
+	if err = a.sendMsgs(ctx, outboundMessages); err != nil {
 		return nil, errors.Trace(err)
 	}
 

diff --git a/cdc/scheduler/internal/v3/replication/replication_manager.go b/cdc/scheduler/internal/v3/replication/replication_manager.go
@@ -902,6 +902,8 @@ func (r *Manager) CleanMetrics() {
 	slowestTableStageCheckpointTsLagHistogramVec.Reset()
 	slowestTableStageResolvedTsLagHistogramVec.Reset()
 	slowestTableRegionGaugeVec.Reset()
+	slowestTablePullerResolvedTs.Reset()
+	slowestTablePullerResolvedTsLag.Reset()
 }
 
 // SetReplicationSetForTests is only used in tests.