Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace "endpoint_url" parameter in PurviewCollectionsClient class for "account_name" parameter #235

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edobrynin-dodo
Copy link

We use "account_name" parameter in core.PurviewClient class, because it's enough to build endpoint_url from it.
This PR applies the same logic to PurviewCollectionsClient class: you only need to pass account_name, and the endpoint url will be created inside the related functions

@wjohnson
Copy link
Owner

Hi, @edobrynin-dodo thank you for your interest in PyApacheAtlas and willingness to contribute to the project!

Unfortunately, this might not work as well for all users as there are some cases where we need to construct the endpoint url in advance (due to some internal naming conventions at Microsoft for our testing / internal versions of Purview).

However, I agree, this could be simplified. I would gladly accept a solution that keeps it simple but limits the areas that would have to change the url if a user was specifying a different domain / sub-domain beyond the account name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants