Recover on Bitcoin Core #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pythcoiner
force-pushed
the
liana_recover
branch
from
8ecc392
to
bfc137a
Compare
darosior
reviewed
Aug 22, 2023
pythcoiner
force-pushed
the
liana_recover
branch
3 times, most recently
from
9fa5736
to
def40d0
Compare
|
Now ready to review, just told me if you feel we need more detail. |
darosior
reviewed
Aug 27, 2023
doc/RECOVER.md
Outdated
Comment on lines
48
to
62
| output: | ||
| ``` | ||
| [ | ||
| { | ||
| "success": false, | ||
| "error": { | ||
| "code": -5, | ||
| "message": "Provided checksum '8ldsjayd' does not match computed checksum 'rgmh0m0p'" | ||
| } | ||
| }, | ||
| { | ||
| "success": false, | ||
| "error": { | ||
| "code": -5, | ||
| "message": "Provided checksum '8ldsjayd' does not match computed checksum 'u7dlz0cc'" |
There was a problem hiding this comment.
It would be much cleaner to call getdescriptorinfo and get the checksum from there. Triggering an error on purpose is confusing and error messages are usually unreliable.
There was a problem hiding this comment.
right, i forgot to fix that, prior to finding out there's a bug in importdescriptor (' are dropped and not count as hardened path) the checksum from getdescriptorinfo was not matching, so i decide to go this ugly way instead
doc/RECOVER.md
Outdated
| We now got the correct checksum, replace wrong ones in the command: | ||
|
|
||
| ```shell | ||
| bitcoin-cli -signet -rpcwallet=liana importdescriptors '[{"desc": "wsh(or_d(pk([a5c6b76e/48h/1h/0h/2h]tpubDF5861hj6vR3iJr3aPjGJz4rNbqDCRujQ21mczzKT5SiedaQqNVgHC8HT9ceyxvMFRoPMx4P6HAcL3NZrUPhRUbwCyj3TKSa64bAfnE3sLh/0/*),and_v(v:pkh([c477fd13/48h/1h/0h/2h]tpubDFn7iPbFqGrTQ2aRACNsUK1MXQR4Z6dYfU2nD1WA9ifSaia642j3Wah4n5pBUEpERNWGJsyv3Dv5qwBabC9TLQrwSboKzukw9wmurGu7XVH/0/*),older(3))))#rgmh0m0p", "range": [0,10000], "timestamp": 1682920310, "active": true, "internal":false}, {"desc": "wsh(or_d(pk([a5c6b76e/48h/1h/0h/2h]tpubDF5861hj6vR3iJr3aPjGJz4rNbqDCRujQ21mczzKT5SiedaQqNVgHC8HT9ceyxvMFRoPMx4P6HAcL3NZrUPhRUbwCyj3TKSa64bAfnE3sLh/1/*),and_v(v:pkh([c477fd13/48h/1h/0h/2h]tpubDFn7iPbFqGrTQ2aRACNsUK1MXQR4Z6dYfU2nD1WA9ifSaia642j3Wah4n5pBUEpERNWGJsyv3Dv5qwBabC9TLQrwSboKzukw9wmurGu7XVH/1/*),older(3))))#u7dlz0cc", "range": [0,10000], "timestamp": 1682920310, "active": true, "internal":true}]' |
There was a problem hiding this comment.
Why this timestamp? You should discuss the wallet birthdate and rescan.
There was a problem hiding this comment.
i don't know where this timestamp from 😲
told me what you think about the fix...
pythcoiner
force-pushed
the
liana_recover
branch
2 times, most recently
from
7e519ca
to
9f170d3
Compare
pythcoiner
force-pushed
the
liana_recover
branch
from
9f170d3
to
eb1e013
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #375