Get ordered list of recovery paths #547
Conversation
There was a problem hiding this comment.
Thanks for the PR. I think it's the right first step toward #517.
Regarding the code. As i mentioned in #517 (comment) i think we should convey somehow that the vector will never be empty, if possible.
This new interface should also be tested. For instance with a unit test against a descriptor that comports multiple timelocks.
Regarding the PR, please squash your commits.
|
Regarding conveying somehow that the vector will never be empty, I can look into a way of ensuring that. For the new interface, this will be effected and tested as suggested, and added in another PR, once I get the go-ahead to implement this function for it. |
There was a problem hiding this comment.
For the new interface, this will be effected and tested as suggested, and added in another PR, once I get the go-ahead to implement this function for it.
What go-ahead? I agree it's better to do the GUI integration in another PR but this one introduces a new API that needs to be tested.
.cirrus.yml
Outdated
| tar -xzf bitcoin-24.1-x86_64-linux-gnu.tar.gz | ||
| export BITCOIND_PATH=bitcoin-24.1/bin/bitcoind | ||
| curl -O https://bitcoincore.org/bin/bitcoin-core-25.0/bitcoin-25.0-x86_64-linux-gnu.tar.gz | ||
| echo "33930d432593e49d58a9bff4c30078823e9af5d98594d2935862788ce8a20aec bitcoin-25.0-x86_64-linux-gnu.tar.gz" | sha256sum -c |
There was a problem hiding this comment.
Unrelated change? You must have messed up the rebase. :)
The new function gets the ordered list, as discussed as part of #517