Skip to content

[DO NOT MERGE] RN77 new arch #3721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 29 commits into
base: rn76-old-arch
Choose a base branch
from
Open

[DO NOT MERGE] RN77 new arch #3721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
c05b635
RN77 upgrade + new arch
M-i-k-e-l May 7, 2025
3d4cad6
Remove TextInputDelKeyHandlerPackage (Android)
M-i-k-e-l May 7, 2025
3004293
KeyboardAccessoryView on Android - fix crash (one bug left)
M-i-k-e-l May 8, 2025
2849be7
Pressing on dismiss (x) only fully works the second time - a very com…
M-i-k-e-l May 8, 2025
6b4b1bf
Remove unused code
M-i-k-e-l May 8, 2025
436f0da
HighlighterViewManager - fix (use new API)
M-i-k-e-l May 8, 2025
78f55fd
Fix gesture handler changed style
M-i-k-e-l May 20, 2025
56fb161
Fix images (unrelated)
M-i-k-e-l May 20, 2025
a46bc21
Fix PanViewScreen (unrelated)
M-i-k-e-l May 20, 2025
2d76207
Fix dragging in SortableList and SortableGridList
M-i-k-e-l May 25, 2025
50c7644
Update navigation
M-i-k-e-l May 25, 2025
3429111
Change iOS back to Objective-C
M-i-k-e-l May 25, 2025
f4cd863
Fix screen - border color
M-i-k-e-l May 25, 2025
db5509f
Revert to older reanimated and gesture-handler versions
M-i-k-e-l May 26, 2025
bca8230
Drawer - fix animation flickering
M-i-k-e-l May 27, 2025
8f25560
Remove comment
M-i-k-e-l May 27, 2025
6350059
StackAggregator - several fixes - see https://github.com/wix/react-na…
M-i-k-e-l May 27, 2025
160155c
Drawer - fix color not being shown with multiple buttons (RectButton …
M-i-k-e-l May 27, 2025
ddca74f
Fix
M-i-k-e-l May 27, 2025
5b71dda
Fix
M-i-k-e-l May 27, 2025
b3ae5f0
Fix iOS (setimmediate)
M-i-k-e-l May 29, 2025
2962046
remove UIManager.setLayoutAnimationEnabledExperimental
Inbal-Tish Jun 3, 2025
8d65eff
Merge branch 'rn76-old-arch' into rn77-new-arch
M-i-k-e-l Jun 3, 2025
c8e888b
Update RNN
M-i-k-e-l Jun 3, 2025
176e88a
Merge branch 'rn76-old-arch' into rn77-new-arch
M-i-k-e-l Jun 9, 2025
0a6c868
Merge branch 'rn76-old-arch' into rn77-new-arch
M-i-k-e-l Jun 9, 2025
b3dfb98
Fix TS
M-i-k-e-l Jun 9, 2025
d37b5c4
Fix snapshot
M-i-k-e-l Jun 9, 2025
938d001
Merge branch 'rn76-old-arch' into rn77-new-arch
M-i-k-e-l Jun 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ buildscript {
minSdkVersion = 26
compileSdkVersion = 35
targetSdkVersion = 34
ndkVersion = "26.1.10909125"
RNNKotlinVersion = "1.9.25"
ndkVersion = "27.1.12297006"
kotlinVersion = "2.0.21"
}
repositories {
mavenLocal()
Expand All @@ -19,7 +19,7 @@ buildscript {
classpath("com.facebook.react:react-native-gradle-plugin")
classpath("org.jetbrains.kotlin:kotlin-gradle-plugin")

classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$RNNKotlinVersion"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
}
}

Expand Down
2 changes: 1 addition & 1 deletion android/gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ reactNativeArchitectures=armeabi-v7a,arm64-v8a,x86,x86_64
# your application. You should enable this flag either if you want
# to write custom TurboModules/Fabric components OR use libraries that
# are providing them.
newArchEnabled=false
newArchEnabled=true

# Use this property to enable or disable the Hermes JS engine.
# If set to false, you will be using JSC instead.
Expand Down
3 changes: 1 addition & 2 deletions demo/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import {UIManager, I18nManager} from 'react-native';
import {I18nManager} from 'react-native';
import {navigationData as menuStructure} from './screens/MenuStructure';
import {loadDemoConfigurations} from './configurations';

UIManager.setLayoutAnimationEnabledExperimental && UIManager.setLayoutAnimationEnabledExperimental(true); // eslint-disable-line
I18nManager.allowRTL(true);

module.exports = {
Expand Down
126 changes: 96 additions & 30 deletions demo/src/screens/__tests__/__snapshots__/TextFieldScreen.spec.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1522,16 +1522,38 @@ exports[`TextField Screen renders screen 1`] = `
numberOfLines={1}
onLayout={[Function]}
style={
{
"backgroundColor": "transparent",
"color": "#6E7881",
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
"opacity": 0,
"writingDirection": "ltr",
}
[
{
"backgroundColor": "transparent",
"color": "#20303C",
"writingDirection": "ltr",
},
undefined,
{
"color": "#6E7881",
},
undefined,
undefined,
{},
undefined,
undefined,
undefined,
[
{},
[
{},
{
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
},
],
{
"opacity": 0,
},
],
]
}
testID="undefined.floatingPlaceholder"
>
Expand Down Expand Up @@ -2118,16 +2140,38 @@ exports[`TextField Screen renders screen 1`] = `
numberOfLines={1}
onLayout={[Function]}
style={
{
"backgroundColor": "transparent",
"color": "#20303C",
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
"opacity": 0,
"writingDirection": "ltr",
}
[
{
"backgroundColor": "transparent",
"color": "#20303C",
"writingDirection": "ltr",
},
undefined,
{
"color": "#20303C",
},
undefined,
undefined,
{},
undefined,
undefined,
undefined,
[
{},
[
{},
{
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
},
],
{
"opacity": 0,
},
],
]
}
testID="undefined.floatingPlaceholder"
>
Expand Down Expand Up @@ -2433,16 +2477,38 @@ exports[`TextField Screen renders screen 1`] = `
numberOfLines={1}
onLayout={[Function]}
style={
{
"backgroundColor": "transparent",
"color": "#20303C",
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
"opacity": 0,
"writingDirection": "ltr",
}
[
{
"backgroundColor": "transparent",
"color": "#20303C",
"writingDirection": "ltr",
},
undefined,
{
"color": "#20303C",
},
undefined,
undefined,
{},
undefined,
undefined,
undefined,
[
{},
[
{},
{
"fontFamily": "System",
"fontSize": 16,
"fontWeight": "400",
"lineHeight": 24,
},
],
{
"opacity": 0,
},
],
]
}
testID="undefined.floatingPlaceholder"
>
Expand Down
4 changes: 2 additions & 2 deletions demo/src/screens/componentScreens/AnimatedImageScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import _ from 'lodash';
import {AnimatedImage, Colors} from 'react-native-ui-lib'; //eslint-disable-line

const SampleImages = [
'https://static.pexels.com/photos/50721/pencils-crayons-colourful-rainbow-50721.jpeg',
'https://static.pexels.com/photos/60628/flower-garden-blue-sky-hokkaido-japan-60628.jpeg'
'https://images.pexels.com/photos/2529146/pexels-photo-2529146.jpeg?auto=compress&cs=tinysrgb&dpr=1&w=500',
'https://images.pexels.com/photos/2529158/pexels-photo-2529158.jpeg?auto=compress&cs=tinysrgb&dpr=1&w=500'
];

export default class AnimatedImageScreen extends Component {
Expand Down
2 changes: 1 addition & 1 deletion demo/src/screens/componentScreens/SortableListScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export default SortableListScreen;
const styles = StyleSheet.create({
itemContainer: {
height: 52,
borderColor: Colors.$outlineDefault,
borderBottomColor: Colors.$outlineDefault,
borderBottomWidth: 1
},
selectedItemContainer: {
Expand Down
2 changes: 1 addition & 1 deletion demo/src/screens/componentScreens/StackAggregatorScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export default class StackAggregatorScreen extends Component {
containerStyle={{marginTop: 12}}
onItemPress={this.onItemPress}
collapsed={false}
contentContainerStyle={{backgroundColor: Colors.red70}}
backgroundColor={Colors.red70}
// itemBorderRadius={10}
// buttonProps={{color: Colors.green30, labelStyle: {...Typography.text80, fontWeight: '500'}}}
>
Expand Down
2 changes: 1 addition & 1 deletion demo/src/screens/componentScreens/TabControllerScreen/tab3.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ class Tab2 extends Component {
<Avatar
size={50}
source={{
uri: 'https://static.pexels.com/photos/60628/flower-garden-blue-sky-hokkaido-japan-60628.jpeg'
uri: 'https://images.pexels.com/photos/2529159/pexels-photo-2529159.jpeg?auto=compress&cs=tinysrgb&dpr=1&w=500'
}}
/>
<Text text40 marginL-20>
Expand Down
6 changes: 3 additions & 3 deletions demo/src/screens/incubatorScreens/PanViewScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import React, {Component} from 'react';
import {StyleSheet, ScrollView} from 'react-native';
import {FlatList} from 'react-native-gesture-handler';
import {FlatList, GestureHandlerRootView} from 'react-native-gesture-handler';
import {
Assets,
View,
Expand Down Expand Up @@ -147,7 +147,7 @@ class PanViewScreen extends Component {
render() {
const {showToast, showDialog} = this.state;
return (
<View style={styles.root}>
<GestureHandlerRootView style={styles.root}>
<View marginL-page height={50} centerV>
<Text text50>New Pan View</Text>
</View>
Expand All @@ -163,7 +163,7 @@ class PanViewScreen extends Component {
</ScrollView>
{showToast && this.renderToast()}
{showDialog && this.renderDialog()}
</View>
</GestureHandlerRootView>
);
}
}
Expand Down
5 changes: 4 additions & 1 deletion demo/src/screens/nativeComponentScreens/HighlightOverlayViewScreen.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@ export default class HighlightOverlayViewScreen extends PureComponent {
}

componentDidMount() {
this.setState({showFTE: true});
// setting timeout to allow Android's transition animation to complete
setTimeout(() => {
this.setState({showFTE: true});
}, 1000);
}

onRefUpdated(ref) {
Expand Down
3 changes: 1 addition & 2 deletions docuilib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,10 @@
"@types/react": "^17.0.14",
"@types/react-helmet": "^6.1.2",
"@types/react-router-dom": "^5.1.8",
"metro-react-native-babel-preset": "0.76.9",
"metro-react-native-babel-preset": "0.77.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-native-linear-gradient": "2.6.2",
"react-native-reanimated": "3.16.7",
"react-native-shimmer-placeholder": "^2.0.9",
"react-native-ui-lib": "snapshot",
"shell-utils": "^1.0.10",
Expand Down
5 changes: 2 additions & 3 deletions docuilib/plugins/uilib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,12 @@ module.exports = ({siteDir}, _options) => {
path.resolve(siteDir, 'src'),
path.resolve(siteDir, 'node_modules/react-native-web'),
path.resolve(siteDir, 'node_modules/react-native-ui-lib'),
// // just for not getting warnings
path.resolve(siteDir, 'node_modules/react-native-shimmer-placeholder'),
path.resolve(siteDir, 'node_modules/react-native-reanimated'),
path.resolve(siteDir, 'node_modules/react-native-linear-gradient')
// // end just for not getting warnings
// just for not getting warnings
// path.resolve(siteDir, 'node_modules/react-native-haptic-feedback'),
// path.resolve(siteDir, 'node_modules/react-native-animatable'),
// path.resolve(siteDir, 'node_modules/react-native-reanimated'),
// path.resolve(siteDir, 'node_modules/react-native-svg'),
// path.resolve(siteDir, 'node_modules/react-native-svg-transformer'),
// path.resolve(siteDir, 'node_modules/@react-native-community/netinfo'),
Expand Down
Loading