perf(iOS): avoid blocking a worker during component render - #8359
Open
OskarEichler wants to merge 1 commit into
Open
perf(iOS): avoid blocking a worker during component render#8359OskarEichler wants to merge 1 commit into
OskarEichler wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performance problem and fix
RNNStackPresenter.renderComponentsdispatched to a global high-priority queue, dispatched setup back to the main queue, then blocked the global worker withdispatch_group_wait(..., DISPATCH_TIME_FOREVER)until the React top-bar background reported ready.For
waitForRendercomponents, a slow or failed render could occupy that worker indefinitely. The worker and synchronization primitive are unnecessary because readiness is already callback-based.This change keeps setup asynchronous on the main queue and forwards readiness back to the main queue without blocking any worker. Completion ordering and main-thread delivery remain unchanged.
Regression coverage
The presenter test now exercises the render callback path and verifies completion is delivered on the main thread. The focused presenter suite passes 10/10.
Verification
build-for-testingsucceededRNNStackPresenterTest: 10/10 passed on an iPhone 16 Pro simulator (iOS 26.5)git diff --checkpassedBreaking changes
None. This removes internal blocking while preserving asynchronous callback order and thread affinity.