fix(Android): restore custom row listener on reattach - #8356
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and fix
BottomTabsCustomRowregistered its process-wide configuration listener only during construction and removed it when detached.BottomTabsCustomRowAttacher.ensureRowHostedOncan detach and reattach the same row when its host changes, leaving that row permanently unsubscribed from later configuration updates.This change ties the listener to the actual view lifecycle:
onAttachedToWindowonDetachedFromWindowThe listener store is a set, so attachment registration remains idempotent.
Regression coverage
The new Robolectric test verifies that:
Verification
git diff --checkpassedBreaking changes
None. This restores expected updates for an existing row after re-hosting.