Scope appearance listener state per animator - #8352
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
BaseViewAppearanceAnimatorreuses one show listener and one hide listener across every replacement animator. Each listener's cancellation flag is sticky: once a hide is interrupted by show, later hide animators inherit the cancelled state and permanently skip their end-state cleanup, leaving the view visible instead of gone.Fix
Attach a fresh listener to each replacement animator so cancellation state belongs to exactly that animator. This removes shared mutable listener state and prevents old/new animator callbacks from contaminating one another.
Breaking changes
None. Completed animations retain their existing states; a later animation now completes normally after an earlier instance was cancelled.
Test plan
View.GONE.VISIBLE; the fixed focused suite passes 9/9.git diff --checkpasses.