Handle non-navigation Android activities safely - #8351
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Both Android bridge implementations force-cast React Native's current
ActivitytoNavigationActivity. If an OAuth, relay, permission, or other valid foreground Activity is current—or no Activity is current—the TurboModule or legacy lifecycle/command path can throwClassCastExceptioninstead of waiting for navigation to become foreground again. This also covers the unsafe cast reported in #8048.Fix
NavigationActivity, matching existing null-activity gatingsetRootcurrentActivityproperty access withgetCurrentActivity()Breaking changes
None. A state that previously crashed is now logged accurately and safely skipped; normal
NavigationActivitycommand/lifecycle behavior is unchanged. Commands are not queued by this patch.Test plan
AppCompatActivityforeground; exact baseline throwsClassCastException.git diff --checkpasses.