-
Couldn't load subscription status.
- Fork 1.9k
React Native 0.81 support #4847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, what is the current status on this? When can we expect a new version that supports React Native 0.81.4? |
|
@Baer05 i will creat a preview right now still have problems with a few tests |
|
Hi, Could you please share an update on when this PR (#4847) is expected to be merged? Appreciate your time and effort on this — having a timeline or status update would really help us plan our next steps. 🙏 |
|
@gosha212 , what do you say if we release some |
|
Please check the latest |
|
I've just tested it on my app (RN .82.0 so a little newer than .81.x) and can confirm that it now launches my app and tests are running (this is a new install as I've only just started using detox on this app) Before it would come up with a refelection error (this is not the case anymore) on a side note for others with the newer build process, if you are going down the releaseE2E route (to keep the production release as pro-guarded as possible) you may need to add to |
|
Same on my end. I can also confirm that I'm getting the |
|
@mduchev Can you check that you are on 20.44 and you run detox build |
|
@cleathley Thanks for the note. We are looking on a solution that will do it automatically. |
|
@gosha212 I was in fact using the latest alpha version and I did run build beforehand. Can it be a cache issue maybe then? |
|
@mduchev Try to clean everything with |
|
@gosha212 Clearing cache and clean checkout didn't help. I had to recreate the package-lock file. I guess npm messed that up again. I can confirm that it's working as expected now. Thank you for your effort. |
|
@Maschga any fix for below error ? |
|
This error should be fixed with this PR. |
|
@Maschga so nothing need to change from my side or ... ? |
|
Here is a support for 0.82: #4853. |
|
Thank you @gosha212 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pretty good but there's a blocker
...ll/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt
Outdated
Show resolved
Hide resolved
.../detox/src/full/java/com/wix/detox/reactnative/idlingresources/timers/JavaTimersReflected.kt
Show resolved
Hide resolved
...ll/java/com/wix/detox/reactnative/idlingresources/animations/AnimatedModuleIdlingResource.kt
Show resolved
Hide resolved
Co-authored-by: d4vidi <[email protected]>
Co-authored-by: d4vidi <[email protected]>
Co-authored-by: d4vidi <[email protected]>
|
@cleathley can you please let me know , how did you fixed java.lang.NoSuchFieldException: error. |
|
@jawadkhan653 You need to upgrade to the latest alpha and rebuild your app. Try |
_@jawadkhan653 you want to use the 44.alpha tag.. ie in your
Works fine under .82 (and I'm using all the usual libs (raw RN app not expo))._ EDIT: looks like |
|
20.44.0 is out |
|
@cleathley you can use waitFor in this case |
|
@gosha212 20.44.0 will work fine for 0.82? |
@gosha212 I've tried that (aswell as wrapping the test with disableSync). Looking at the console it's not even attempting the test until the splash screen times out (just a setInterval, navigate combo). even setting the timeout to say 10 seconds it still won't process the test until after the transition |
|
Can you share a simple demo app? |
|
@gosha212 Will work on a app tommorow (I'm in Australia). I've recorded a video of the launch and put a few console logs in but yes it should be quiet basic as it's just launchs the emulator and has a single test. I've tried launching the emualator by both a beginALL in the actual test and an a beginALL() in a setup file and passing it into jest. The test in the video is just an empty it('') block but it doesn't run to after the app has transisioned. |




Description
In this pull request, I have fixed detox to support RN 81