Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate shell completions on install #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jalaziz
Copy link

@jalaziz jalaziz commented Oct 12, 2022

Homebrew can automatically generate and install completions for bash,
zsh, and fish. For now, completion is limited to bash and zsh until
graphite adds fish support.

This simplifies the installation steps for homebrew users.

@jalaziz jalaziz force-pushed the generate-completions branch from 31746b5 to 295d3c7 Compare February 9, 2023 04:14
@jalaziz jalaziz force-pushed the generate-completions branch from 295d3c7 to d52c23e Compare June 28, 2023 06:40
@jalaziz
Copy link
Author

jalaziz commented Jun 28, 2023

@dbalatero @goldjacobe Sorry to be a pest and ping you directly, but any chance this could be reviewed?

This helps simply the graphite CLI install to a single step.

@jalaziz jalaziz force-pushed the generate-completions branch from d52c23e to b18db02 Compare June 28, 2023 06:56
@jalaziz jalaziz force-pushed the generate-completions branch from b18db02 to 5555c43 Compare July 14, 2023 18:11
@goldjacobe
Copy link
Contributor

Thanks for these PRs, I'll integrate soon (we have some other inflight changes to the release process I want to finalize first)

@goldjacobe
Copy link
Contributor

this diff doesn't seem to work as expected.

@jalaziz
Copy link
Author

jalaziz commented Jul 22, 2023

@goldjacobe What issue are you seeing? No completions installed?

I had run into some issues during the last rebased, but thought I fixed everything.

I'm rebasing to test again.

Homebrew can automatically generate and install completions for bash,
zsh, and fish. For now, completion is limited to bash and zsh until
graphite adds fish support.

This simplifies the installation steps for homebrew users.
@jalaziz jalaziz force-pushed the generate-completions branch from 5555c43 to c880a52 Compare July 22, 2023 23:50
@jalaziz
Copy link
Author

jalaziz commented Jul 22, 2023

@goldjacobe I just rebased and tested and it's installing the shell completions for me (I'm using zsh). Are you not seeing completions installed?

For zsh, the shell completions are installed to $(brew --prefix)/share/zsh/site-functions/_graphite. Depending on your setup, you may have to load the completions from Homebrew's completion directory: https://docs.brew.sh/Shell-Completion (not needed if you use brew installed shells)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants