-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
i18n(de): Follow i18n guide in islands.mdx
#12705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome changes, I really like your usage of the non-breaking Unicode symbol 🙌
I left some suggestions / questions...
trueberryless
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉🎈🥳
Thanks for the improvementa, randomguy
|
Thanks @randomguy-2650, could you also apply the changes from ec6a116 here? Should be a quick one, then we are good to merge! |
This comment was marked as resolved.
This comment was marked as resolved.
yanthomasdev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Good job 🙌
Description
This PR updates the
islands.mdxfile to follow the German i18n guide more closely.Related issues & labels