-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(reference): Update astro:assets reference for new Astro 6.0 behavior #12639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
You need to update the upgrade guide as well, see #12322 |
|
So based on this, if Like, this isn't true anymore:
That was the reason to have the section, so I'd suggest we just move the |
|
I removed the section entirely. I'll try to think of something to put in the upgrade guide |
|
It's not going to let me suggest fixes for the links that are broken now that there is no more section called "Responsive Images." In general, use the following ideas to fix these:
In most cases, just removing the link should be fine. In a case where e.g. it says "image properties AND responsive image properties", it's now just "image properties." As for the
For the guide page, it's fine to be a little bit more explainy. These are generally known as properties you use when making images responsive. If you have any doubt, when you update these, they will at least become changes I can make suggestions on top of! |
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small comment, and cleaning up all the now-broken anchor links, and this looks great!
Co-authored-by: Sarah Rainsberger <[email protected]>
Co-authored-by: Florian Lefebvre <[email protected]>
Co-authored-by: Armand Philippot <[email protected]>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a nit regarding the table of contents, otherwise the contents looks great to me!
sarah11918
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description (required)
In Astro 6, you can crop images and set fit and position without needing a layout. I'll admit, I don't fully understand how layouts work since I wasn't around when it was added, but hopefully I got it.
Related issues & labels (optional)
withastro/astro#14629