fix: session regeneration #12864
Merged
fix: session regeneration #12864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 943d49f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
github-actions
bot
removed
the
pkg: example
CodSpeed Performance ReportMerging #12864 will not alter performanceComparing Summary
|
ematipico
reviewed
Dec 30, 2024
|
The existing tests are unit only - this is why they pass, as they don't model the interaction with the request rendering/cookie setting process. If you can point me at an example of a simple existing SSR / cookie setting & checking test, I can give it a shot. |
|
@ematipico added a test that fails on main but succeeds on this branch. |
ascorbic
reviewed
Jan 2, 2025
ematipico
reviewed
Jan 2, 2025
ematipico
approved these changes
Jan 2, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ensures that session IDs get regenerated when
regenerate()is called. This fixes #12863.pnpm exec changesetTesting
Built astro with this change locally and ran it against https://stackblitz.com/edit/github-muwk6ati-gxwf5xkb?file=src%2Fpages%2Findex.astro and it functions as expected (new uuid shown on every refresh).
Docs
Docs should not be needed - this aligns the code's functionality with the current docs.