fix: match index files only by using entire basename #12815
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code would cause file names like `index.xml.ts` to be treated as index files, when they aren't (the file basename excluding the extension `.ts` is `index.xml`, and `index` should be the index file). To match index files only, match the entire first half of the basename when splitting by the last occurrence of the period/file extension delimiter. Pedantically this might not be correct -- i.e. some file extensions actually span multiple delimiters, like index.tar.gz. But in that case it's not an index file as well, so I think this is fine. Fixes withastro#12675
🦋 Changeset detectedLatest commit: 65516f1 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
CodSpeed Performance ReportMerging #12815 will not alter performanceComparing Summary
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ascorbic
reviewed
Jan 3, 2025
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| 'astro': minor | |||
There was a problem hiding this comment.
This should be a patch because it's a bugfix not new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous code would cause file names like
index.xml.tsto be treated as index files, when they aren't (the file basename excluding the extension.tsisindex.xml, andindexshould be the index file). To match index files only, match the entire first half of the basename when splitting by the last occurrence of the period/file extension delimiter.Pedantically this might not be correct -- i.e. some file extensions actually span multiple delimiters, like
index.tar.gz. But in that case it's not an index file as well, so I think this is fine.Fixes #12675
Changes
pnpm exec changesetTesting
This was tested with my website repository that I'm using to migrate to Astro. This may need more tests to make sure it is not a breaking change.
Docs
Possibly -- files that were considered index files may not be and vice versa. Although I think this change should only include files that were previously excluded by the
.startswith("index.")check./cc @withastro/maintainers-docs for feedback!