Remove baseUrl
requirement for tsconfig path aliases
#12731
Draft
+282
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of TypeScript 4.1,
baseUrl
is not required for tsconfig path aliases to work.baseUrl
is required in Astro, however.The TypeScript docs actively discourage people from setting
baseUrl
:In this PR I’ve removed the explicit
baseUrl
check and early return. Rather than bailing ifbaseUrl
is not set, Astro now defaults to abaseUrl
of'.'
. This aligns with TypeScript’s path resolving functionality. You can read more in the TypeScript documentation page about module resolution: https://www.typescriptlang.org/docs/handbook/modules/reference.html#relationship-to-baseurlChanges
baseUrl
now defaults to'.'
ifbaseUrl
is not set in your tsconfig fileTesting
I copied the
alias-tsconfig
fixture over to a new fixture,alias-tsconfig-no-baseurl
.Docs
I removed usage of
baseUrl
from the README forvite-plugin-config-alias
.