DP-362 - Add Global Docker Compose Stop #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dcbickfo
commented
Jun 12, 2024
•
dcbickfo
commented
- Added the stop command to global docker compose
- Removed the now obsolete version tag from the docker-compose.yml: https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-optional
- Updated readme
- Updated changelog
- Update to the github action to pull v1 of goreleaser (there is a major version release (v2) which removed some options currently used)
| @@ -35,7 +35,7 @@ jobs: | |||
| uses: goreleaser/goreleaser-action@v3 | |||
| with: | |||
| distribution: goreleaser | |||
| version: latest | |||
| version: "~> v1" | |||
There was a problem hiding this comment.
What does this do?
There was a problem hiding this comment.
Since the last change goreleaser pushed a v2 that latest started pulling (and failing the CI due to a command removal). I felt updating to v2 of goreleaser was out of scope for this PR so I changed it to pull the most recent version of v1.
| @@ -0,0 +1,43 @@ | |||
| /* | |||
| Package commands Copyright © 2021 NAME HERE <EMAIL ADDRESS> | |||
There was a problem hiding this comment.
Why do we need license stuff in here?
There was a problem hiding this comment.
Good question. I don't see why it's needed but all the other commands have it at the top so I added it.
Really just a case of if everyone else does it, would you. In this case yes ... yes I would. 😂
skawaguchi-flipp
approved these changes
Jun 12, 2024
etam-pro
approved these changes
Jun 12, 2024
|
What's the difference between |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.