Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete PDF output handler #367

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

tobiasfalk
Copy link

@tobiasfalk tobiasfalk commented May 29, 2024

Everything was already prepaired, and I just had to make some minor changes. I do not know why this was prepaired but not finished.

Everythnig was alredy prepairt and I just had to make some minor changes.
I do not know why this was prepaired but not finished.
@amotl amotl changed the title Added final stuff for PDF output Complete PDF output handler Jun 4, 2024
Copy link
Contributor

@martinrieder martinrieder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as you do not need drawing frames and BOM, this is fine. It does not solve your issue #354 then.

@tobiasfalk
Copy link
Author

@martinrieder yes and no, Yes it does not add frames and so. And No since I originally just wanted a PDF output and was not interested in the frame, since PDF is just a robuster vector graphics format and is less dependent on the interpreter.

@martinrieder
Copy link
Contributor

martinrieder commented Jun 15, 2024

Maybe we need to make some destinguishment through another CLI argument that would request BOM output, templates and metadata to be included, which is currently only supported for HTML.

EDIT: Alternatively, the list of output formats for the -f CLI switch might be extended to contain PDF either with or without BOM. See the PR on CLI here:

@kvid
Copy link
Collaborator

kvid commented Oct 6, 2024

@martinrieder wrote:

Maybe we need to make some destinguishment through another CLI argument that would request BOM output, templates and metadata to be included, which is currently only supported for HTML.

EDIT: Alternatively, the list of output formats for the -f CLI switch might be extended to contain PDF either with or without BOM.

If you want to include a BOM in the diagram (as in #227) and optionally also a frame, then such extra elements will be added to all graphical output types, and controlling this by different output type specifiers makes no sense to me. A common specifyer for what to include in the diagram is then needed, and the HTML output should be adjusted accordingly to avoid doubled BOM and frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants