Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


TaskWPB-21456 [iOS] Make syncV2 available for apiVersion 7

Issue

In order to deprecate legacy sync, we need to make syncV2 available to supported versions below 8: 5, 6, 7.

This PR makes it available for apiVersion 7

  • Add constant for syncV2 check
  • Remove dead code
  • [TMP] run critical flows with apiVersion 7

Testing

  1. Set preferredAPIVersion to v7
  2. login
    check for (parsing) errors

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍒

@netbe netbe closed this Nov 3, 2025
@netbe netbe reopened this Nov 3, 2025
@netbe netbe enabled auto-merge November 3, 2025 10:03
@github-actions
Copy link
Contributor Author

github-actions bot commented Nov 3, 2025

Test Results

3 535 tests   3 508 ✅  4m 28s ⏱️
  488 suites     27 💤
    4 files        0 ❌

Results for commit eb1376b.

@netbe netbe requested review from a team, caldrian and johnxnguyen and removed request for a team November 3, 2025 10:27
@netbe netbe added this pull request to the merge queue Nov 3, 2025
Merged via the queue into develop with commit f91a72e Nov 3, 2025
12 checks passed
@netbe netbe deleted the feat/legacy-sync-apiv7-cherry-pick branch November 3, 2025 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants