Skip to content

chore: start treating warnings as errors - WPB-11987 #3816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 3, 2025
Merged

chore: start treating warnings as errors - WPB-11987 #3816

merged 11 commits into from
Nov 3, 2025

Conversation

@caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 31, 2025 •
edited by github-actions bot
Loading

EpicWPB-11987 [iOS] Xcode Warnings

Issue

This PR uses the compiler flag -warnings-as-errors for WireLogging when running on CI.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025 •
edited
Loading

Test Results

100 tests   100 ✅  8s ⏱️
 23 suites    0 💤
  3 files      0 ❌

Results for commit 2157fb3.

♻️ This comment has been updated with latest results.

@caldrian caldrian requested a review from netbe October 31, 2025 14:25
netbe
netbe reviewed Oct 31, 2025
View reviewed changes
netbe
netbe reviewed Oct 31, 2025
View reviewed changes
netbe
netbe reviewed Oct 31, 2025
View reviewed changes
netbe
netbe reviewed Oct 31, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a couple comments before approving

@caldrian caldrian enabled auto-merge October 31, 2025 15:55
netbe
netbe approved these changes Nov 3, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@caldrian caldrian added this pull request to the merge queue Nov 3, 2025
Merged via the queue into develop with commit 79b62e3 Nov 3, 2025
11 checks passed
@caldrian caldrian deleted the chore/treat-warnings-as-errors-WPB-11987 branch November 3, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@netbe netbe netbe approved these changes

@jullianm jullianm jullianm approved these changes

@samwyndham samwyndham Awaiting requested review from samwyndham

Assignees

@caldrian caldrian

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@caldrian @netbe @jullianm