-
Notifications
You must be signed in to change notification settings - Fork 24
fix: send message - WPB-20880 #3815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netbe
commented
Oct 31, 2025
wire-ios-request-strategy/Sources/Object Syncs/Helpers/ZMChangeTrackerBootstrap.m
Show resolved
Hide resolved
Contributor
Test Results 5 files 583 suites 11m 51s ⏱️ For more details on these failures, see this check. Results for commit 0a980eb. ♻️ This comment has been updated with latest results. |
johnxnguyen
approved these changes
Nov 3, 2025
jullianm
approved these changes
Nov 3, 2025
zenkins
pushed a commit
that referenced
this pull request
Nov 3, 2025
6 tasks
6 tasks
This was referenced Nov 5, 2025
6 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When sending a message, if something goes wrong, the message is stuck in pending state. This is because the changeTrackers that are added after init of StrategyDirectory are not added. This PR fixes this
Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: