Skip to content

Conversation

@netbe
Copy link
Collaborator

@netbe netbe commented Oct 31, 2025

BugWPB-20880 [iOS] Failed image message prevent any further message to be sent

Issue

When sending a message, if something goes wrong, the message is stuck in pending state. This is because the changeTrackers that are added after init of StrategyDirectory are not added. This PR fixes this

Testing

  1. turn networklink with 100% bad network
  2. send a message
  3. kill app
  4. relaunch app with normal network
  5. the message gets sent

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@netbe netbe requested review from johnxnguyen and jullianm October 31, 2025 12:07
@github-actions
Copy link
Contributor

github-actions bot commented Oct 31, 2025

Test Results

    5 files    583 suites   11m 51s ⏱️
4 406 tests 4 375 ✅ 27 💤 4 ❌
4 406 runs  4 379 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit 0a980eb.

♻️ This comment has been updated with latest results.

@netbe netbe enabled auto-merge (squash) November 3, 2025 10:09
@netbe netbe merged commit fa5bc8c into release/cycle-4.9 Nov 3, 2025
13 checks passed
@netbe netbe deleted the fix/send-message-WPB-20880 branch November 3, 2025 13:53
zenkins pushed a commit that referenced this pull request Nov 3, 2025
@github-actions github-actions bot mentioned this pull request Nov 3, 2025
6 tasks
@netbe netbe mentioned this pull request Nov 4, 2025
6 tasks
netbe added a commit that referenced this pull request Nov 6, 2025
@netbe netbe mentioned this pull request Nov 6, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants