-
Notifications
You must be signed in to change notification settings - Fork 24
chore: rename WireLogging to WireLegacyLogging - WPB-14876 #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
caldrian
wants to merge
50
commits into
develop
Choose a base branch
from
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore: rename WireLogging to WireLegacyLogging - WPB-14876 #3813
caldrian
wants to merge
50
commits into
develop
from
chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
+906
−673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cdb65e to
98bd690
Compare
c4b20f6 to
bc48a93
Compare
Test Results 17 files 1 186 suites 11m 42s ⏱️ For more details on these failures, see this check. Results for commit c05793a. ♻️ This comment has been updated with latest results. |
bc48a93 to
e6e68d2
Compare
e6e68d2 to
02bf0b5
Compare
…t-warnings-as-errors-WPB-11987
…name-wirelogging-to-wirelegacylogging-WPB-14876
…name-wirelogging-to-wirelegacylogging-WPB-14876
…6-7f83724bf858469f046dba417b536537352eb56f' into chore/treat-warnings-as-errors-WPB-11987
…name-wirelogging-to-wirelegacylogging-WPB-14876
Base automatically changed from
chore/treat-warnings-as-errors-WPB-11987
to
develop
November 3, 2025 10:27
…me-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876
…r-WPB-14876' into chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876 # Conflicts: # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
…me-wirelogging-to-wirelegacylogging-WPB-14876 # Conflicts: # WireLogging/Sources/WireLegacyLogging/WireLogger+Instances.swift # wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
e0dcbea to
076a3fc
Compare
…me-wirelogging-to-wirelegacylogging-WPB-14876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
As a first step to refactoring the logging this PR moves all existing code from
WireLogginginto a new targetWireLegacyLogging.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: