Skip to content

Conversation

@caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 30, 2025

StoryWPB-14876 [iOS] Create a new WireLogger interface

Issue

As a first step to refactoring the logging this PR moves all existing code from WireLogging into a new target WireLegacyLogging.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch 3 times, most recently from 0cdb65e to 98bd690 Compare October 30, 2025 14:01
@caldrian caldrian marked this pull request as ready for review October 30, 2025 14:52
@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch 2 times, most recently from c4b20f6 to bc48a93 Compare October 30, 2025 15:00
@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2025

Test Results

   17 files  1 186 suites   11m 42s ⏱️
8 883 tests 8 851 ✅ 31 💤 1 ❌
8 896 runs  8 865 ✅ 31 💤 0 ❌

For more details on these failures, see this check.

Results for commit c05793a.

♻️ This comment has been updated with latest results.

@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch from bc48a93 to e6e68d2 Compare October 30, 2025 15:33
@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch from e6e68d2 to 02bf0b5 Compare October 30, 2025 17:09
@caldrian caldrian changed the title chore: rename WireLogging to WireLegacyLogging - WPB-14876 [WIP] chore: rename WireLogging to WireLegacyLogging - WPB-14876 Oct 31, 2025
@caldrian caldrian changed the base branch from develop to chore/treat-warnings-as-errors-WPB-11987 October 31, 2025 14:36
…name-wirelogging-to-wirelegacylogging-WPB-14876
…name-wirelogging-to-wirelegacylogging-WPB-14876
…6-7f83724bf858469f046dba417b536537352eb56f' into chore/treat-warnings-as-errors-WPB-11987
…name-wirelogging-to-wirelegacylogging-WPB-14876
Base automatically changed from chore/treat-warnings-as-errors-WPB-11987 to develop November 3, 2025 10:27
…me-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876
…r-WPB-14876' into chore/rename-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876
…me-wirelogging-to-wirelegacylogging-WPB-14876

# Conflicts:
#	wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
…me-wirelogging-to-wirelegacylogging-WPB-14876

# Conflicts:
#	WireLogging/Sources/WireLegacyLogging/WireLogger+Instances.swift
#	wire-ios-data-model/WireDataModel.xcodeproj/project.pbxproj
@caldrian caldrian force-pushed the chore/rename-wirelogging-to-wirelegacylogging-WPB-14876 branch from e0dcbea to 076a3fc Compare November 5, 2025 15:08
…me-wirelogging-to-wirelegacylogging-WPB-14876
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants