-
Notifications
You must be signed in to change notification settings - Fork 24
chore: move c headers out of wire system - WPB-8907 #3803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
chore: move c headers out of wire system - WPB-8907 #3803
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request refactors the logging infrastructure by moving ZMSLogging.h from WireSystem to individual modules and removes the unused NSData+WireTesting files. The PR also includes Swift toolchain updates and minor improvements.
- Moved
ZMSLogging.hfrom centralized WireSystem module to module-specific headers with tailored macros - Removed unused
NSData+WireTestingfiles from WireTesting project - Updated Swift toolchain version to 6.2 in WireDomain package
- Enhanced Sourcery template to handle array types properly
- Fixed typo in ZMSLog.swift comment
Reviewed Changes
Copilot reviewed 48 out of 50 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wire-ios-utilities/Source/ZMSLogging.h | New module-specific logging header with Error, Warn, and Debug macros |
| wire-ios-transport/Source/Logging/ZMSLogging.h | Updated transport module logging header, removed ZMLogPublic and Foundation import |
| wire-ios-sync-engine/Source/ZMSLogging.h | New sync-engine module-specific logging header with Error, Info, and Debug macros |
| wire-ios-request-strategy/Sources/ZMSLogging.h | New request-strategy module-specific logging header with Info and Debug macros |
| wire-ios-mocktransport/Source/ZMSLogging.h | New mocktransport module-specific logging header with Error and Debug macros |
| wire-ios-data-model/Source/ZMSLogging.h | New data-model module-specific logging header with Error, Warn, and Debug macros |
| wire-ios-system/Source/WireSystem.h | Removed import of centralized ZMSLogging.h |
| WireDomain/Package.swift | Updated Swift tools version to 6.2 and added new Swift language features |
| WirePlugins/Plugins/SourceryPlugin/Stencils/AutoMockable.stencil | Enhanced template to handle array and optional existential types |
| wire-ios-system/Source/ZMSLog.swift | Fixed typo: "usefull" to "useful" |
| Various .m files | Added imports for module-specific ZMSLogging.h headers |
| wire-ios-testing project files | Removed NSData+WireTesting files from public headers |
| wire-ios-system/WireSystem.xcodeproj | Removed ZMSLogging.h from public headers and removed empty Frameworks group |
| Multiple Package.swift files | Removed redundant comment about swift-tools-version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…e-c-headers-out-of-WireSystem-WPB-8907
…e-c-headers-out-of-WireSystem-WPB-8907
…e-c-headers-out-of-WireSystem-WPB-8907
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: can't you remove the ZMSLogger.h completely? looking at the #define we should not be using it
Test Results 8 files 639 suites 8m 34s ⏱️ For more details on these failures, see this check. Results for commit 5bc987f. ♻️ This comment has been updated with latest results. |
…e-c-headers-out-of-WireSystem-WPB-8907
…B-11829' into chore/move-c-headers-out-of-WireSystem-WPB-8907
…4-010dcca40affa272fb0f554f6f1663ebedfed343' into chore/update-sourcery-stencil-WPB-11829
…e-c-headers-out-of-WireSystem-WPB-8907
Issue
WireSystem does not contain any Obj-C code anymore.
Still there are currently three header files with preprocessor-macros used by other projects.
As a small step towards the goal of migrating WireSystem to a Swift package this PR moves
ZMSLogging.hout of WireSystem by creating duplicates in other modules where needed.Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: