fix: leading-trailing-debounder - WPB-21128 #3793
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Sam Wyndham <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in LeadingTrailingDebouncer where conversation message cells displayed incorrect content when updated. The fix involves removing the generic type parameter and improving the state management logic.
Key Changes:
- Simplified
LeadingTrailingDebouncerby removing generic type parameter and usingUUIDdirectly - Fixed state management logic to properly update states dictionary and handle trailing calls
- Added comprehensive test coverage for debouncer behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
ConversationTableViewDataSource.swift |
Removed generic type parameter from debouncer instantiation |
LeadingTrailingDebouncerTests.swift |
Added new test file with three test cases covering single call, first-and-last, and skip scenarios |
LeadingTrailingDebouncer.swift |
Removed generic type constraint, fixed state update bug, added thread safety check, and simplified cooldown logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results1 926 tests 1 899 ✅ 2m 39s ⏱️ Results for commit d38fb07. ♻️ This comment has been updated with latest results. |
caldrian
requested review from
a team,
jullianm and
samwyndham
and removed request for
a team
Co-authored-by: François Benaiteau <[email protected]>
samwyndham
approved these changes
Oct 28, 2025
caldrian
commented
Oct 28, 2025
...os/Wire-iOS/Sources/UserInterface/Conversation/Content/ConversationTableViewDataSource.swift
Show resolved
Hide resolved
6 tasks
caldrian
force-pushed
the
fix/updating-message-cells-WPB-21128
branch
from
478d863 to
93d89a2
Compare
6 tasks
Co-authored-by: zenkins <[email protected]>
…fix/updating-message-cells-WPB-21128
auto-merge was automatically disabled
November 3, 2025 11:08
Pull request was converted to draft
…eapp/wire-ios into fix/updating-message-cells-WPB-21128
…eapp/wire-ios into fix/updating-message-cells-WPB-21128 # Conflicts: # wire-ios-request-strategy/Sources/Payloads/Payload.swift
…ng-message-cells-WPB-21128
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
There is a bug in
LeadingTrailingDebouncerwhich causes conversation message cells to display wrong content when the content is updated.Testing
The new poll app's result cell should now always show the correct result.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: