feat: large document previews - WPB-21022 #3785
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivellaO
requested review from
SyamalaHari,
WilhelmOks,
jullianm and
samwyndham
Test Results386 tests 385 ✅ 1m 14s ⏱️ Results for commit 99cbb32. ♻️ This comment has been updated with latest results. |
WilhelmOks
requested changes
Oct 24, 2025
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...ging/Sources/WireMessagingUI/WireCells/Components/Previews/WireCellsDocumentHeaderView.swift
Show resolved
Hide resolved
OlivellaO
force-pushed
the
feature/large-document-previews
branch
from
f37c449 to
374b0b3
Compare
samwyndham
reviewed
Oct 27, 2025
There was a problem hiding this comment.
Nice work! I will approve after @WilhelmOks comments are addressed
samwyndham
reviewed
Oct 27, 2025
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Outdated
Show resolved
Hide resolved
OlivellaO
force-pushed
the
feature/large-document-previews
branch
2 times, most recently
from
868bd41 to
dfe0f9b
Compare
OlivellaO
force-pushed
the
feature/large-document-previews
branch
2 times, most recently
from
da4e84a to
241bc1d
Compare
WilhelmOks
approved these changes
Oct 28, 2025
samwyndham
approved these changes
Oct 28, 2025
...sagingUI/WireCells/Components/AttachmentsPreviewView/WireCellsLargeDocumentPreviewView.swift
Show resolved
Hide resolved
OlivellaO
force-pushed
the
feature/large-document-previews
branch
from
241bc1d to
579ff4e
Compare
WilhelmOks
approved these changes
Oct 28, 2025
OlivellaO
force-pushed
the
feature/large-document-previews
branch
3 times, most recently
from
014e5b2 to
9f9baa7
Compare
OlivellaO
force-pushed
the
feature/large-document-previews
branch
from
9f9baa7 to
99cbb32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
What was done in this PR:
Testing
Using a version that has Wire Cells enabled send a single document file on a chat.
When single document is shared, large document preview should be shown.
UI test can't be done, no way of mocking AsyncImage.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: