chore: Tests compatible to iPad - WPB-20998

[findms]

WPB-20998 [iOS/QA] XCTest with iPad compatibility

---

Summary

Briefly describe what this PR does.

This PR is about the critical flow tests making it compatible to iPad so that we can run on nightly if all green for ipad as well.
To Achieve this we needed to put some conditions, elements where flow is different from iPhone on iPad.

   @discardableResult
    func onPad(_ block: (() -> Void)? = nil) -> Bool {
        guard UIDevice.current.userInterfaceIdiom == .pad else { return false }
        block?()
        return true
    }

---

Testing

Describe how to verify the changes locally. Attach screenshots or reports if relevant.

Additional Information

any more info, add here.

Note: 1 Test is still pending to be fixed due to issue https://wearezeta.atlassian.net/browse/WPB-21169

[github-actions]

Test Results

2 351 tests   2 323 ✅  3m 6s ⏱️
  374 suites     28 💤
    3 files        0 ❌

Results for commit 98e1802.

[johnxnguyen]

Looks good, just one question. Also please try to fill in the PR description with something to help the reviewer understand what he changes are about.

[johnxnguyen]

question: were these changes part of automatic linting?

[findms]

Some warnings were flagging, tried resolving them.