Skip to content

chore: update CoreCrypto 8.0 - WPB-18877 #3421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 20 commits into
base: release/cycle-4.2
Choose a base branch
from

Conversation

netbe
Copy link
Collaborator

@netbe netbe commented Aug 1, 2025

Issue

Bump to CC 8.0:
https://github.com/wireapp/core-crypto/releases

  • Updates new Types
  • Update tests (DataModel...)
  • Update MockCoreCryptoProtocol
  • create AppVersionMigration 4.2.1 that call coreCrypto.updateDatabaseKey
  • Check AppVersionMigration 4.2.1 is runned if app version is 4.3.0

Testing

TBD


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@KaterinaWire KaterinaWire marked this pull request as ready for review August 6, 2025 07:48
Copy link
Contributor

@jullianm jullianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I added minor suggestions to use an explicit naming coreCrypto... rather than. cc.. on the variable names.

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Test Results

1 files  3 suites   4m 11s ⏱️
6 tests 3 ✅ 0 💤 3 ❌
6 runs  6 ✅ 0 💤 0 ❌

For more details on these failures, see this check.

Results for commit aa91d22.

♻️ This comment has been updated with latest results.

@KaterinaWire KaterinaWire removed their request for review August 15, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants