Skip to content

feat: Reset MLS conversation Additional logic - WPB-18664 #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dmitrysimkin
Copy link
Contributor

@dmitrysimkin dmitrysimkin commented Aug 1, 2025

TaskWPB-18664 [iOS] Process conversation.mls-reset event

Issue

  • Added logic to not handle reset mls conversation if was initiated from same device, by storing a flag in user defaults
  • Fix initiate reset with additional step to fetch refetch conversation after reset to get new groupID
  • updated tests

Testing

Describe how to test.

Optional: attachments like images, videos, etc.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@dmitrysimkin dmitrysimkin marked this pull request as ready for review August 1, 2025 12:42
Copy link
Contributor

github-actions bot commented Aug 1, 2025

Test Results

   20 files  1 176 suites   13m 35s ⏱️
9 068 tests 9 038 ✅ 27 💤 3 ❌
9 080 runs  9 053 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit 9ef6587.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving but left two comments please have a look

@dmitrysimkin dmitrysimkin enabled auto-merge (squash) August 4, 2025 10:46
@dmitrysimkin dmitrysimkin merged commit d97f6b2 into release/cycle-4.3 Aug 4, 2025
27 checks passed
@dmitrysimkin dmitrysimkin deleted the feature/additional-logic-WPB-18664-to-release branch August 4, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants