Skip to content

feat: Add updates in API v10 - WPB-18970 #3415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 5, 2025
Merged

feat: Add updates in API v10 - WPB-18970 #3415

merged 2 commits into from
Aug 5, 2025

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:

Issue

Added changes for network requests that we use

https://wearezeta.atlassian.net/wiki/spaces/ENGINEERIN/pages/1984856066/API+changes+v9+v10

  • Added skip_creator to POST /conversations request
  • made POST /conversations (any some other with same model response) members.self optional
  • Conversation.id was remove in v10 but we already have it optional for other api versions with logic to recover id from qualifiedID
  • Updated POST /get-domain-registration with new response model

Testing

Describe how to test.

Optional: attachments like images, videos, etc.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

netbe
netbe approved these changes Aug 1, 2025
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@dmitrysimkin dmitrysimkin enabled auto-merge August 1, 2025 14:49
@dmitrysimkin
Merge branch 'develop' into feature/migrate-to-API-V10-WPB-18970-2-up…
7f12542 
…dates-cherry-pick

# Conflicts:
#	WireDomain/Sources/WireDomain/Event Processing/ConversationEventProcessor/ConversationMLSResetEventProcessor.swift
#	WireDomain/Tests/WireDomainTests/Event Processing/ConversationEventProcessor/ConversationMLSResetEventProcessorTests.swift
#	wire-ios-data-model/Tests/MLS/MLSServiceTests.swift
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented Aug 5, 2025

Test Results

    4 files    575 suites   3m 28s ⏱️
3 797 tests 3 768 ✅ 27 💤 2 ❌
3 798 runs  3 771 ✅ 27 💤 0 ❌

For more details on these failures, see this check.

Results for commit 7f12542.

@dmitrysimkin dmitrysimkin added this pull request to the merge queue Aug 5, 2025
Merged via the queue into develop with commit 2f019c1 Aug 5, 2025
10 checks passed
@dmitrysimkin dmitrysimkin deleted the feature/migrate-to-API-V10-WPB-18970-2-updates-cherry-pick branch August 5, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@dmitrysimkin dmitrysimkin dmitrysimkin approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

@KaterinaWire KaterinaWire KaterinaWire approved these changes

Assignees

@dmitrysimkin dmitrysimkin

Labels
cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@netbe @dmitrysimkin @johnxnguyen @KaterinaWire