chore: Move making destination views in factory for WireAuth - WPB-19090 #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # WireAuthentication/Sources/WireAuthentication/Components/DetermineAuthMethodComponent.swift # WireAuthentication/Sources/WireAuthentication/Components/LoginViaEmailComponent.swift # WireAuthentication/Sources/WireAuthenticationUI/Mocks/FakeLoginViaEmailFactory.swift # WireAuthentication/Sources/WireAuthenticationUI/Views/Login/LoginViaEmail/LoginViaEmailView.swift # WirePreviewApps/WireAuthenticationApp/ContentView.swift
Test Results87 tests 87 ✅ 21s ⏱️ Results for commit 2354a66. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 88 Passed, 0 Skipped, 7.14s Total Time |
samwyndham
approved these changes
Jul 16, 2025
dmitrysimkin
changed the title
netbe
reviewed
Jul 28, 2025
WireAuthentication/Sources/WireAuthenticationUI/Views/Login/NoHistory/NoHistoryView.swift
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Improve DI in WireAuthentication by moving creating destination views to factory.
Views not wrapped in AnyView, instead created method to create each of destination view in the factory
Testing
Describe how to test.
Optional: attachments like images, videos, etc.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: