fix: MLS service UT - WPB-16280 #2590
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianm
changed the title
samwyndham
approved these changes
Feb 26, 2025
Test Results 1 files 1 suites 4m 38s ⏱️ For more details on these failures, see this check. Results for commit dee036b. ♻️ This comment has been updated with latest results. |
Datadog ReportBranch report: ✅ 0 Failed, 2363 Passed, 0 Skipped, 4m 38.54s Total Time |
jullianm
changed the base branch from
release/cycle-3.118
to
release/cycle-3.119
jullianm
changed the base branch from
release/cycle-3.119
to
release/cycle-3.118
netbe
approved these changes
Mar 4, 2025
dmitrysimkin
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WPB-16280
Issue
Fix UT failing in MLS service with error "stall on main thread". Not exactly sure what happened as I was able to get the test passed multiple times so I simplified the UT, removing the expectations, now the UT runs much quicker.
Checklist
[WPB-XXX].