Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Delete CreateGuestRoomCell & CreateGroupCell - WPB-11612 #2053

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: Delete CreateGuestRoomCell & CreateGroupCell - WPB-11612 #2053

merged 1 commit into from
Oct 17, 2024
+0 −72

Conversation

agisilaos
Copy link
Contributor

@agisilaos agisilaos commented Oct 17, 2024 •
edited by github-actions bot
Loading

TaskWPB-11612 [iOS] Cleanup code around creating guest room (former cells)

With this PR we delete two cells that we don't use anywhere anymore.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test Results

    2 files    293 suites   3m 15s ⏱️
1 808 tests 1 808 ✅ 0 💤 0 ❌
1 816 runs  1 816 ✅ 0 💤 0 ❌

Results for commit 0d55c72.

samwyndham
samwyndham approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@samwyndham samwyndham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧽

@agisilaos agisilaos merged commit 584264a into epic/navigation-overhaul-WPB-6647 Oct 17, 2024
12 of 13 checks passed
@agisilaos agisilaos deleted the chore/delete-deprecated-code branch October 17, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwyndham samwyndham samwyndham approved these changes

@caldrian caldrian caldrian approved these changes

Assignees

@agisilaos agisilaos

Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@agisilaos @samwyndham @caldrian