Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add construct the Password Reset url - WPB-11566 #2044

Merged
merged 1 commit into from
Oct 16, 2024
Merged

fix: Add construct the Password Reset url - WPB-11566 #2044

merged 1 commit into from
Oct 16, 2024
+7 −7

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Oct 16, 2024 •
edited by github-actions bot
Loading

BugWPB-11566 [iOS] Password reset link points to incorrect URL

Issue

We need to construct the passwordrReset URL because it depends on the accountsURL that we got when we switched to another server using deeplink.

Testing

Reset password

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Test Results

    2 files    305 suites   3m 5s ⏱️
1 867 tests 1 867 ✅ 0 💤 0 ❌
1 875 runs  1 875 ✅ 0 💤 0 ❌

Results for commit d258d06.

@datadog-wireapp
Copy link

Datadog Report

Branch report: fix/forgot-password-link-v3
Commit report: 4f894b0
Test service: wire-ios-mono

✅ 0 Failed, 1867 Passed, 0 Skipped, 15.22s Total Time

netbe
netbe reviewed Oct 16, 2024
View reviewed changes
Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove password_reset from url.json

@KaterinaWire KaterinaWire merged commit ebab944 into release/cycle-3.112 Oct 16, 2024
10 of 18 checks passed
@KaterinaWire KaterinaWire deleted the fix/forgot-password-link-v3 branch October 16, 2024 14:05
@github-actions github-actions bot mentioned this pull request Oct 16, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe approved these changes

@samwyndham samwyndham samwyndham approved these changes

@agisilaos agisilaos agisilaos approved these changes

@johnxnguyen johnxnguyen johnxnguyen approved these changes

Assignees
No one assigned
Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KaterinaWire @netbe @samwyndham @agisilaos @johnxnguyen