refactor: process conversation member join event - WPB-10168 #2041
+660
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctor our system message, add UTs - WPB-10168
jullianm
commented
Oct 16, 2024
| ) | ||
|
|
||
| let role = member.conversationRole.map { | ||
| Role.fetchOrCreateRole( |
There was a problem hiding this comment.
I think this could go to a specific repository, I'm thinking the UserRepository but I'm not certain where it makes the most sense. What do you think?
| public func addSystemMessage( | ||
| _ message: SystemMessage, | ||
| to conversation: ZMConversation | ||
| ) async { |
There was a problem hiding this comment.
This was factored out of the ZMSystemMessage legacy extension, so we can use it directly from the repo. There are other places in WireDomain where we still use the legacy helper method that will be refactored as well if this change is approved.
Test Results270 tests 270 ✅ 10s ⏱️ Results for commit 700ea5d. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ctor our system message, add UTs - WPB-10168
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationMemberJoinevent.Testing
UTs cover the following use cases, ensuring that
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: