feat: New Design for Creating New Group Conversation Screen to match Design Specs - WPB-11589 #2036
+414
−338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increased font size
+ Update colors
…7' into feat/Update-Create-Conversation-Design
…ate-Conversation-Design
…ate-Conversation-Design
…ate-Conversation-Design
…ate-Conversation-Design
…ate-Conversation-Design
echoes-hq
bot
added
the
echoes: features
Test Results 2 files 293 suites 2m 48s ⏱️ Results for commit 5854fdf. ♻️ This comment has been updated with latest results. |
agisilaos
commented
Oct 15, 2024
...os/Wire-iOS/Sources/UserInterface/Conversation/Create/Cells/ConversationCreateNameCell.swift
Show resolved
Hide resolved
…ate-Conversation-Design
jullianm
approved these changes
Oct 16, 2024
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionFooterView.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionHeader.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionTableFooter.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionTableFooter.swift
Show resolved
Hide resolved
...os/Wire-iOS/Sources/UserInterface/Conversation/Create/Cells/ConversationCreateNameCell.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/WireTextField.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/WireTextField.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionFooterView.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionHeader.swift
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Components/Views/SectionTableFooter.swift
Show resolved
Hide resolved
...os/Wire-iOS/Sources/UserInterface/Conversation/Create/Cells/ConversationCreateNameCell.swift
Outdated
Show resolved
Hide resolved
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/WireTextField.swift
Outdated
Show resolved
Hide resolved
…ate-Conversation-Design
…ate-Conversation-Design
wire-ios/Wire-iOS/Sources/UserInterface/Conversation/Create/WireTextField.swift
Show resolved
Hide resolved
KaterinaWire
approved these changes
Oct 16, 2024
agisilaos
merged commit f65d121
into
epic/navigation-overhaul-WPB-6647
10 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--
This PR implements updates to the Create Group Conversation screen, ensuring it aligns with the latest design specifications. It includes changes to the layout, styling, and the behavior of UI components.
Changes:
• Implemented new design for the conversation options.
• Updated section headers and footers.
• Applied new design for the text field input.
• Adjusted fonts and colors for navigation bar items.
• Removed the optionsToggle, making the cells show by default.
• Cleaned up unused code related to the old design.
Testing:
• Verified visual alignment with the latest design specifications.
• Manual testing of the conversation options behavior and navigation bar to ensure correct functionality and appearance.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: