refactor: process conversation access update event - WPB-10164 #2028
Conversation
echoes-hq
bot
added
echoes: maintenance
Test Results2 669 tests 2 669 ✅ 8m 38s ⏱️ Results for commit 8f5048f. ♻️ This comment has been updated with latest results. |
|
|
||
| await context.perform { | ||
| localConversation.accessModeStrings = event.accessModes.map(\.rawValue) | ||
| localConversation.accessRoleStringsV2 = accessRoles.map(\.rawValue) |
There was a problem hiding this comment.
I think saves should happen on a higher level. For instance:
- Get batch of pending events
- Process batch of events (no saves in-between)
- After successfully processing all events in batch, one single save, then delete those pending events (they are consumed now
We need to take care that any committed work isn't repeated in case of any interruption to the event processing.
| await context.perform { | ||
| localConversation.accessModeStrings = event.accessModes.map(\.rawValue) | ||
| localConversation.accessRoleStringsV2 = accessRoles.map(\.rawValue) |
There was a problem hiding this comment.
Shouldn't this be part of the repository?
|
|
||
| await context.perform { | ||
| localConversation.accessModeStrings = event.accessModes.map(\.rawValue) | ||
| localConversation.accessRoleStringsV2 = accessRoles.map(\.rawValue) |
There was a problem hiding this comment.
I think saves should happen on a higher level. For instance:
- Get batch of pending events
- Process batch of events (no saves in-between)
- After successfully processing all events in batch, one single save, then delete those pending events (they are consumed now
We need to take care that any committed work isn't repeated in case of any interruption to the event processing.
| domain: conversationID.domain | ||
| ) | ||
|
|
||
| let accessRoles = if let legacyAccessRole = event.legacyAccessRole { |
There was a problem hiding this comment.
Hmm... do we even need to handle the legacy roles anymore? The newer roles are always present.
WPB-10164
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationAccessUpdateevent.Testing
UTs cover the following use cases, ensuring that:
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: