Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add "UI" suffix to target names in WireUI - WPB-6647 #2025

Merged
merged 5 commits into from
Oct 14, 2024
Merged

chore: add "UI" suffix to target names in WireUI - WPB-6647 #2025

merged 5 commits into from
Oct 14, 2024

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Oct 14, 2024 •
edited by github-actions bot
Loading

TopicWPB-6647 [iOS] Navigational Overhaul

Issue

This PR adds the UI suffix to the targets of WireUI.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: features End-user visible changes intended to create customer value label Oct 14, 2024
@caldrian caldrian force-pushed the chore/rename-ui-targets-WPB-6647 branch from f4a74f8 to d0fcf26 Compare October 14, 2024 08:34
caldrian
caldrian commented Oct 14, 2024
View reviewed changes
WireAPI/Package.resolved Outdated Show resolved Hide resolved
WireAnalytics/[email protected] Outdated Show resolved Hide resolved
.github/workflows/_reusable_run_tests.yml Show resolved Hide resolved
WireFoundation/.swiftpm/WireUtilities.xctestplan Outdated Show resolved Hide resolved
@caldrian caldrian changed the title chore: rename UI targets to add - WPB-6647 chore: add "UI" suffix to target names in WireUI - WPB-6647 Oct 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 14, 2024 •
edited
Loading

Test Results

    7 files    384 suites   3m 7s ⏱️
2 333 tests 2 333 ✅ 0 💤 0 ❌
2 341 runs  2 341 ✅ 0 💤 0 ❌

Results for commit 99e88e6.

♻️ This comment has been updated with latest results.

@caldrian @jullianm
Fix typo
2f0084f 
Co-authored-by: Jullian Mercier <[email protected]>
@caldrian caldrian added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit 1eac983 Oct 14, 2024
11 of 12 checks passed
@caldrian caldrian deleted the chore/rename-ui-targets-WPB-6647 branch October 14, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agisilaos agisilaos agisilaos approved these changes

@jullianm jullianm jullianm approved these changes

Assignees

@caldrian caldrian

Labels
echoes: features End-user visible changes intended to create customer value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caldrian @agisilaos @jullianm